Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: diff parsing for valid ranges is incorrect #124

Closed
chingor13 opened this issue Oct 5, 2020 · 0 comments · Fixed by #125
Closed

review: diff parsing for valid ranges is incorrect #124

chingor13 opened this issue Oct 5, 2020 · 0 comments · Fixed by #125
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

A patch string includes the starting line and the number of lines in the diff on the left/right side. However, lines may be unchanged between the diffs (they are there to provide context/anchors). We need to ignore the unchanged files when calculating the lines that are commentable.
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 5, 2020
@chingor13 chingor13 mentioned this issue Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: range parsing chingor13/code-suggester
1 participant
@chingor13