use protoc v3.9.0-rc-1 for PHP #655
Conversation
Ads ask to try using `protoc` v3.9.0-rc-1 for PHP (download location is [here](https://github.com/protocolbuffers/protobuf/releases/download/v3.9.0-rc1/protoc-3.9.0-rc-1-linux-x86_64.zip)). Internal bug ID: 131809012.
googlebot
added
the
cla: yes
|
@alexander-fenster For ads it is doable, because they will have their own WORKSPACE file, where they can specify different version of protoc. I.e. it is ok to have different protobuf version per "org" (Ads or Cloud), but it is not Ok to use different protobuf version per language within same org. |
|
@alexander-fenster Notice what is happening here: Ads request affects cloud as well (i.e. if Ads is Ok using 3.9.0-rc1 for PHP (i.e. non-stable version) it does not mean that Google Cloud is Ok doing same). |
This release includes the following fixes: - wrap all parameters in 'apostrophes' #656 - use protoc v3.9.0-rc-1 for PHP #655 Also, the following gapic-generator changes are included: - go: remove enoding on header request param key googleapis/gapic-generator#2858 - Python: Sync 'list_*' method docstrings with implementation googleapis/gapic-generator#2857 - Python: Add client options googleapis/gapic-generator#2853
This release includes the following fixes: - wrap all parameters in 'apostrophes' #656 - use protoc v3.9.0-rc-1 for PHP #655 Also, the following gapic-generator changes are included: - go: remove enoding on header request param key googleapis/gapic-generator#2858 - Python: Sync 'list_*' method docstrings with implementation googleapis/gapic-generator#2857 - Python: Add client options googleapis/gapic-generator#2853
|
@vam-google @alexander-fenster
This is spot on, and unfortunately we weren't okay with using a release candidate. We've got a backlog of PRs which we can't progress on now - I originally came here to see if we could pin to v3.8 at generation time but see we have a challenge given the ads team and their requirements. Are there any recommended solutions? edit: |
Ads ask to try using
protocv3.9.0-rc-1 for PHP (download location is here). Internal bug ID: 131809012.@vam-google: it might be difficult to stop using this protoc override feature :( We need to think what other options we have, since this case shows that using one version across all languages might be really needed (PHP needs to use RC1 ASAP which we likely cannot use across all languages).