This repository has been archived by the owner on Mar 1, 2022. It is now read-only.
pass the specific YAML loader to yaml.load #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the advice from [this page](https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation) to prevent the deprecation messages like this one: ``` /artman/artman/config/loader.py:99: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details. json_string = json.dumps(yaml.load(f)) /artman/artman/config/loader.py:126: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details. artman_config_json_string = json.dumps(yaml.load(f)) ```
googlebot
added
the
cla: yes
|
@lukesneeringer @eoogbe @vam-google Can you please review this one line* change? |
alexander-fenster
added a commit
that referenced
this pull request
Jun 26, 2019
Changes included in this release are fixes: In artman: - pass the specific YAML loader to yaml.load #648 - fix --local runs #650 In gapic-generator: - samplegen: add sample_config.proto to the config_java_proto BUILD target googleapis/gapic-generator#2852 - go: URL encode x-goog-request-params googleapis/gapic-generator#2851 - ruby: ake it possible to pass metadata to the operations client googleapis/gapic-generator#2856
Merged
alexander-fenster
added a commit
that referenced
this pull request
Jun 26, 2019
Changes included in this release are fixes: In artman: - pass the specific YAML loader to yaml.load #648 - fix --local runs #650 In gapic-generator: - samplegen: add sample_config.proto to the config_java_proto BUILD target googleapis/gapic-generator#2852 - go: URL encode x-goog-request-params googleapis/gapic-generator#2851 - ruby: ake it possible to pass metadata to the operations client googleapis/gapic-generator#2856
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the advice from this page to prevent the deprecation messages like this one: