Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How often is this repository synced with googleapis? #88

Closed
johanbrandhorst opened this issue Apr 6, 2021 · 6 comments
Closed

How often is this repository synced with googleapis? #88

johanbrandhorst opened this issue Apr 6, 2021 · 6 comments
Labels
type: question Request for information or clarification. Not an issue.

Comments

@johanbrandhorst
Copy link

I had a quick look at a few protobuf files from googleapis and it seems like this repository is not being kept up-to-date with the changes made to protobuf files within googleapis. Is this repository still being migrated to, as detailed in googleapis/go-genproto#92 (comment)?

@noahdietz noahdietz added the type: question Request for information or clarification. Not an issue. label Apr 6, 2021
@noahdietz
Copy link
Contributor

noahdietz commented Apr 6, 2021

This repository is not actively synced. It occasionally gets spot updates for some dependent packages that have yet to be migrated. No it is not being migrated to, go-genproto continues to be generated based on protos from github.com/googleapis/googleapis. That repo is the most up-to-date project and should be used instead.

I will close this now, but if there is anything else, please feel free to comment.

@johanbrandhorst
Copy link
Author

May be worth putting in the README that this repository is deprecated then?

@timburks
Copy link

I'd also like to see the state of this repo clarified. Browsing the googleapis collection, it's not immediately clear which directories are common protos (and suggested for reuse) and which are APIs. People with inside knowledge might use the presence of service config to identify APIs (or something else), but this repo provided helpful clarity on what's available for reuse.

If this repo is a subset of googleapis, and if googleapis remains authoritative and available, would it be helpful to have an update script that pulls new types and updates from the googleapis repo so that this could be updated by external contributors? I'd be happy to draft a PR with that.

@timburks timburks reopened this Apr 14, 2021
@jankrynauw
Copy link

Comparing for example the option go_package entries in the color.proto files:

both have the exact same option go_package entry of:
option go_package = "google.golang.org/genproto/googleapis/type/color;color";

Yet looking at the generated protobufs behind these go_package entries, they seem to reflect the official googleapis definitions. For example, the protobuf for phone_number.proto is available in the go library but nowhere defined in this (api-common-proto) repository.

For go packages at least, the golden source of protobufs referred to in this repo definitions, is not driven by this repo, but instead driven by the googleapis repo, There is therefore a real danger of inconsistent definitions between proto definitions in this library and the underlying go packages imported.

@parthea
Copy link
Contributor

parthea commented Jan 31, 2022

I'm going to close this issue as obsolete as it is recommended to use the googleapis repo instead.

@parthea parthea closed this as completed Jan 31, 2022
@johanbrandhorst
Copy link
Author

May be worth putting in the README that this repository is deprecated then?

Has this been done yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

5 participants