Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing instruction on using proto js package #118

Open
jasonclg opened this issue Nov 22, 2022 · 0 comments
Open

Confusing instruction on using proto js package #118

jasonclg opened this issue Nov 22, 2022 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@jasonclg
Copy link

According to the note in https://github.com/googleapis/api-common-protos#packages

Note that if using these packages, you will still need a local copy of these protos when using protoc, but you will not need to ship compiled versions of them. (This is consistent with protoc's default behavior of only providing compiled output for the files specifically requested, and not their imports.)

This does not seem right for js package.
I protoc compiled my proto file with those imports from google-proto-files.
Apparently I have to ship compiled version of imported protos too because the google-proto-files does not contain them (unlike the packages for other languages or imports from google/protobuf/).

@jasonclg jasonclg added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

1 participant