Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Video.js 5 #122

Closed
dguiley opened this issue Oct 13, 2015 · 9 comments
Closed

Support for Video.js 5 #122

dguiley opened this issue Oct 13, 2015 · 9 comments

Comments

@dguiley
Copy link

dguiley commented Oct 13, 2015

Is there an ETA for videojs 5 support?

Thanks.

@shawnbuso
Copy link
Contributor

No ETA yet but we'll be testing to see if everything works as expected. It looks like the plugin we use, videojs-contrib-ads, still only supports up to 4.12.4.

@dguiley
Copy link
Author

dguiley commented Oct 13, 2015

Thanks Shawn.

@dguiley
Copy link
Author

dguiley commented Oct 24, 2015

Very interested in this, as we are working on bugs that may go away with vjs5.

Best.
-- Dathan

On Oct 24, 2015, at 10:01 AM, TixxyTAM [email protected] wrote:

Hey Shawn videojs-contrib-ads has an upgrade for vjs 5...
I'v tested vjs ima with that... but it's not working...
I want to know whether you are willing to add support for vjs5


Reply to this email directly or view it on GitHub.

@shawnbuso
Copy link
Contributor

Did a quick test and the ads plugin we use is erroring with VJS 5. This is a KI on their end, will hopefully be resolved once videojs/videojs-contrib-ads#121 is finalized.

@shawnbuso
Copy link
Contributor

Blocked by videojs/videojs-contrib-ads#121

@aldfeu
Copy link

aldfeu commented Dec 7, 2015

any update with videojs-contrib-ads 3.1 ?
It still does not seems to work.

@akestner
Copy link

+1 on an update as well. Seems that videojs/videojs-contrib-ads#121 has been merged.

@shawnbuso
Copy link
Contributor

Still working on this one but seeing errors from the latest contrib ads plugin. Blocked on videojs/videojs-contrib-ads/issues/139

@jmccraw
Copy link

jmccraw commented Dec 28, 2015

I had that issue, too. I think I solved by upgrading to a more recent version of Videojs (I used 5.4.4). The version in the example didn't have the $ method for query selectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants