-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Video.js 5 #122
Comments
No ETA yet but we'll be testing to see if everything works as expected. It looks like the plugin we use, videojs-contrib-ads, still only supports up to 4.12.4. |
Thanks Shawn. |
Very interested in this, as we are working on bugs that may go away with vjs5. Best.
|
Did a quick test and the ads plugin we use is erroring with VJS 5. This is a KI on their end, will hopefully be resolved once videojs/videojs-contrib-ads#121 is finalized. |
Blocked by videojs/videojs-contrib-ads#121 |
any update with videojs-contrib-ads 3.1 ? |
+1 on an update as well. Seems that videojs/videojs-contrib-ads#121 has been merged. |
Still working on this one but seeing errors from the latest contrib ads plugin. Blocked on videojs/videojs-contrib-ads/issues/139 |
I had that issue, too. I think I solved by upgrading to a more recent version of Videojs (I used 5.4.4). The version in the example didn't have the |
Is there an ETA for videojs 5 support?
Thanks.
The text was updated successfully, but these errors were encountered: