Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(README): use the correct RewardedAd property name #929

Closed
wants to merge 1 commit into from
Closed

fix(README): use the correct RewardedAd property name #929

wants to merge 1 commit into from

Conversation

enricoangelon
Copy link

Description

The property named 'adLoadCallback' of RewardedAd.load() shown in the example is outdated, It has been replaced by 'rewardedAdLoadCallback'.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [ x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • [x ] All existing and new tests are passing.
  • [ x] I updated/added relevant documentation (doc comments with ///).
  • [x ] The analyzer (flutter analyze) does not report any problems on my PR.
  • [x ] I read and followed the [Flutter Style Guide].
  • [x ] I signed the [CLA].
  • [x ] I am willing to follow-up on review comments in a timely manner.

@google-cla
Copy link

google-cla bot commented Oct 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@malandr2 malandr2 self-requested a review November 14, 2023 15:53
@malandr2
Copy link
Collaborator

malandr2 commented Nov 14, 2023

@enricoangelon thanks for the fix. I can merge as soon as the missing CLA test is resolved

@malandr2
Copy link
Collaborator

Closing due to inactivity - will address in a separate PR

@malandr2 malandr2 closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants