Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Upgrade visibility_detector version #807

Closed
aintend-com opened this issue Mar 27, 2023 · 10 comments
Closed

[Proposal] Upgrade visibility_detector version #807

aintend-com opened this issue Mar 27, 2023 · 10 comments
Labels
dependencies Pull requests that update a dependency file proposal Proposal for a change

Comments

@aintend-com
Copy link

Please update the visibility_detector

@huycozy huycozy added the in triage Issue currently being evaluated label Mar 28, 2023
@huycozy
Copy link
Collaborator

huycozy commented Mar 28, 2023

Hi @aintend-com
Can you be more specific on the reason for this? Does the current version conflict with another package?

@huycozy huycozy added the feedback required Further information is requested label Mar 28, 2023
@jj-hoeksema
Copy link

Hi, it does not directly conflict in my app, but I would like to update to visibility_detector 0.4.0 because of the improvements

@coderof19clc7
Copy link

I want to use the package markdown_widget and google_mobile_ads but they conflict because markdown_widget depends on visibility_detector ^0.4.0+2. So please update the dependencies of google_mobile_ads

@huycozy huycozy added proposal Proposal for a change dependencies Pull requests that update a dependency file and removed feedback required Further information is requested in triage Issue currently being evaluated labels Apr 4, 2023
@huycozy huycozy changed the title visibility_detector Update [Proposal] Upgrade visibility_detector version Apr 4, 2023
@timothyhoang-google
Copy link
Collaborator

This looks like a Flutter request as opposed to a GMA Flutter plugin request.

Flutter 3.7 introduces a fix that makes usage of visibility_detector for impression tracking obsolete for the GMA Flutter plugin. We recommend updating to version 2.4, which adds a new flag, AdWidget.optOutOfVisibilityDetectorWorkaround. Setting this to true lets you opt out of the fix added for #580.

@coderof19clc7
Copy link

As what I see is that this package has nothing changed and it still conflict with markdown_widget because of difference in the version of dependency visibility_detector, why this issue marked as completed ? Actually i'm new to Github so please explain if I have anything misunderstand, thank you.

@coderof19clc7
Copy link

@huycozy do you guys have any plan on updating the visibility_detector dependency for this package ?

@huycozy
Copy link
Collaborator

huycozy commented May 8, 2023

@timothyhoang-google I think the visibility_detector should be upgraded to the latest version since it's conflicted with other packages. Users can use GMA Flutter plugin version 2.4 and above, but it's still being used visibility_detector: ^0.3.3.

Meanwhile, for anyone facing the issue, you can use dependency_overrides as a workaround for this:

dependency_overrides:
  visibility_detector: ^0.4.0+2

@timothyhoang-google
Copy link
Collaborator

@huycozy - thanks for flagging this issue.

We will need to do another major version release to increase the min Flutter version required and increase the visibility detector version. @jjliu15 will work on this.

@mulderpf
Copy link

This is closed, but no fix is available for this issue yet...

@Quichaco
Copy link

Quichaco commented Oct 10, 2023

@mulderpf While waiting for the update you can add this :

google_mobile_ads:
    git:
      url: https://github.com/googleads/googleads-mobile-flutter.git
      ref: 9dabf7b0d1865866f5deb6934f1ae510989c00e9
      path: packages/google_mobile_ads/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file proposal Proposal for a change
Projects
None yet
Development

No branches or pull requests

7 participants