Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HyperLogLogPlusPlus should be serializable #3

Open
nielsbasjes opened this issue Jul 11, 2019 · 2 comments
Open

HyperLogLogPlusPlus should be serializable #3

nielsbasjes opened this issue Jul 11, 2019 · 2 comments

Comments

@nielsbasjes
Copy link

To allow inclusion of this in systems like Apache Beam and Apache Flink the HyperLogLogPlusPlus class should be serializable.
I ran into this while trying to implement a UDF for Apache Flink, there serializability is mandatory.

Also when trying to put an instance of the HyperLogLogPlusPlus class through a simple Beam pipeline resulted in

Caused by: java.io.NotSerializableException: com.google.zetasketch.HyperLogLogPlusPlus
	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
	at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
	at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)

@zfraa zfraa closed this as completed Jul 18, 2019
@zfraa zfraa reopened this Jul 18, 2019
@chaitanyapilaka
Copy link

Hey! I am interested in this as well because I'm trying to use the the said class in Apache beam. Has there been any progress on it? If not, is there anyway I can be helpful in moving this forward?

@zfraa
Copy link
Member

zfraa commented Jan 28, 2020

@chaitanyapilaka Did you check out https://beam.apache.org/releases/javadoc/2.16.0/org/apache/beam/sdk/extensions/zetasketch/HllCount.html? That provides an off-the-shelf Beam integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants