Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPACES_BEFORE_COMMENT column mode violates PEP8 policy of two spaces before comment #675

Open
reagle opened this issue Feb 11, 2019 · 0 comments

Comments

@reagle
Copy link

reagle commented Feb 11, 2019

Now that #667 is resolved, I have a concern about the behavior: specifying multiple values so as to use column alignment results in inline comments preceded by a single space. Shouldn't there always be two spaces as a minimum regardless of column alignment?

For example, this PEP8 compliant code:

else:
    class args:
        cgi = True                # called from cgi
        chase = True              # Follow freeplane links to other local maps
        long_url = False          # Use short 'oldid' URLs for mediawikis
        urls_online_only = False  # Emit urls for @online only
        pretty = False            # Print as HTML with citation at end
        query = None              # Query the bibliographies
        query_c = None            # Query re.compiled

loses a space

else:

    class args:
        cgi = True               # called from cgi
        chase = True             # Follow freeplane links to other local maps
        long_url = False         # Use short 'oldid' URLs for mediawikis
        urls_online_only = False # Emit urls for @online only
        pretty = False           # Print as HTML with citation at end
        query = None             # Query the bibliographies
        query_c = None           # Query re.compiled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant