Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of the Instance Metadata Service instead of using an API Key #24

Open
JulesDT opened this issue Dec 29, 2020 · 1 comment
Open

Comments

@JulesDT
Copy link

JulesDT commented Dec 29, 2020

Hello,

I realized when browsing this project that this will require an API Key to work whereas the Webrisk API seems to be compatible with tokens generated by the IMDS service.
More specifically, using the library https://godoc.org/cloud.google.com/go/webrisk/apiv1beta1 that is referenced in the Webrisk doc doesn't require an API Key.

Is this a feature that is planned for this project?

Or would you be willing to accept a PR to add a new API struct that would implement the api interface and leverage the webrisk library above to use the IMDS instead of an API Key?

@JulesDT JulesDT changed the title Allow use of the IMDS instead of using an API Key Allow use of the Instance Metadata Service instead of using an API Key Dec 29, 2020
@rvilgalys
Copy link
Collaborator

Hello,

Sorry we're just getting to this now, I noticed this when a similar feature was requested in #52.

We've recently brought this repo into Google's internal source control & maintenance which now releases to Github, so cannot accept PRs right now -- however adding more than just API key auth is something I'd like to get added soon as it's been brought up with other customers. I will update here with details as they're available.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants