Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom completion for :Glaive #8

Closed
glts opened this issue Jan 6, 2014 · 3 comments
Closed

Add custom completion for :Glaive #8

glts opened this issue Jan 6, 2014 · 3 comments

Comments

@glts
Copy link
Contributor

glts commented Jan 6, 2014

I suspect you will want to add this sooner or later, might as well have an issue on the issue tracker!

Basic custom completion for a :command is easy to add but tremendously helpful for the user.

:Gl<Tab>
:Glaive 
:Glaive myp<Tab>
:Glaive myplugin 

and perhaps even

:Glaive myplugin som<Tab>
:Glaive myplugin somesetting

More info at :h :command-completion.

@dbarnett
Copy link
Contributor

dbarnett commented Jan 6, 2014

Indeed, I'd been wanting completion for :Glaive and just forgot to file a bug for it after moving to github. I also just filed #9 for adding a mechanism to query the current flag values, which is very related and might get done at the same time.

Contributions very welcome here. It's something I'd love to see but haven't had time to work on.

@glts
Copy link
Contributor Author

glts commented Jan 11, 2014

I spent a short while looking into this for fun.

I wonder why you chose to make the notation different from Vim's notation.

:set list             :Glaive plug list
:set nolist     vs    :Glaive plug !list
:set list!      vs    :Glaive plug ~list
:set invlist    vs    :Glaive plug ~list
:set list?      vs    TBD
:set list&      vs    N/A

Is there a technical reason for this? I think acceptance would be better if users could apply the same pattern as in standard :set.

@dbarnett
Copy link
Contributor

Good point. I raised the question separately in #12. I'd like to hear what @Soares thinks about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants