Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Add evidence metadata to redis on upload #1543

Open
aarontp opened this issue Sep 6, 2024 · 1 comment
Open

[FR]: Add evidence metadata to redis on upload #1543

aarontp opened this issue Sep 6, 2024 · 1 comment
Labels
enhancement Needs triage New issues that need triage

Comments

@aarontp
Copy link
Member

aarontp commented Sep 6, 2024

What is the feature you are proposing?

Add the evidence metadata to redis on upload so that after evidence has been uploaded that it can be queried by the command line.

What would this feature improve or what problem would it solve?

This would allow users to query evidence after upload even if it's not processed yet. This may be useful if the upload happens separately from the processing or is done by another user. It also makes it easier for the user to understand what the current evidence state is because if the evidence doesn't show up after querying it looks like an error may have occurred.

What alternatives have you considered?

No response

@aarontp aarontp added enhancement Needs triage New issues that need triage labels Sep 6, 2024
@jleaniz
Copy link
Collaborator

jleaniz commented Oct 3, 2024

Turbinia currently stores evidence metadata from serialized Evidence objects. When you upload a file manually via the command line without an associated Turbinia Request, an Evidence object is not created. So the only metadata available is a file name, a path and optionally, a file hash. It seems like a bad idea to create a generic Evidence object with just a path attribute to keep track of uploaded files.

We would have to implement a few changes to the way Evidence objects are stored in order to accomplish this. Another option would be to track uploaded files separately from Evidence objects that are associated with actual requests. Maybe that would make more sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Needs triage New issues that need triage
Projects
None yet
Development

No branches or pull requests

2 participants