Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the behaviour of StopTimeEvent on different schedule relationships. #503

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miklcct
Copy link

@miklcct miklcct commented Sep 25, 2024

Fixes #490

Copy link

google-cla bot commented Sep 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gcamp
Copy link
Contributor

gcamp commented Sep 25, 2024

I'm not a fan of fields changing meaning depending on the context, if we would add a way to specify schedule time I would prefer having a separate field.

In addition, I'm sure you've seen that the usage of ADDED has been discouraged. I would think defining clearly ADDED would be useful before adding more capabilities to it.

@leonardehrenfried
Copy link
Contributor

I agree. Clarifying ADDED has the highest priority IMO.

@miklcct
Copy link
Author

miklcct commented Sep 25, 2024

I am going to work on another PR for specifying ADDED (and REPLACEMENT) types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying both the scheduled time and delay in StopTimeEvent for added and duplicated trips.
3 participants