Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Providing a stack array in trace events causes an import error #1174

Open
krroy03 opened this issue Dec 8, 2017 · 1 comment
Open

Providing a stack array in trace events causes an import error #1174

krroy03 opened this issue Dec 8, 2017 · 1 comment

Comments

@krroy03
Copy link

krroy03 commented Dec 8, 2017

screen shot 2017-12-07 at 7 21 21 pm

In the Trace Event Format Google Docs, it states that we can put a stack array in duration or complete trace events, just like this:

"stack" : ["string1", "string2", "string3"]

but when I add this into my trace events, and import the json file into the web page, I get this error:

'TypeError: this.model_.resolveStackToStackFrame_ is not a function
at TraceEventImporter.getStackFrameForEvent_ (chrome://tracing/tracing.js:4752:42)

After checking this function on the repo, it seems like the function hasn't been completed yet and returns undefined.

resolveStackToStackFrame_(pid, stack) {
// TODO(alph,fmeawad): Add codemap resolution code here.
return undefined;
}

Just wanted to know if you guys were planning on implementing it soon, and if not, maybe remove it from the google docs for now?

@dan-ryan
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants