Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: support Go 1.16 #2446

Closed
dvyukov opened this issue Feb 19, 2021 · 0 comments
Closed

all: support Go 1.16 #2446

dvyukov opened this issue Feb 19, 2021 · 0 comments

Comments

@dvyukov
Copy link
Collaborator

dvyukov commented Feb 19, 2021

Go 1.16 is released. I think we need to switch main CI to 1.16 and leave "old" CI on 1.14 for now (leave 1.15 w/o testing).

dvyukov added a commit to dvyukov/syzkaller that referenced this issue Feb 19, 2021
Currently it produces false reports with Go1.16:

tools/syz-runtest/runtest.go:271:6: SA5011: possible nil pointer dereference
	req.Output = a.Output
	    ^
tools/syz-runtest/runtest.go:272:6: SA5011: possible nil pointer dereference
	req.Info = a.Info
	    ^
sys/fuchsia/fidlgen/main.go:27:17: SA5011: possible nil pointer dereference
	arch := target.KernelHeaderArch
	               ^

All these are preceeded with log.Fatalf, which is strange...

Update google#2446
dvyukov added a commit to dvyukov/syzkaller that referenced this issue Feb 19, 2021
dvyukov added a commit that referenced this issue Feb 20, 2021
Currently it produces false reports with Go1.16:

tools/syz-runtest/runtest.go:271:6: SA5011: possible nil pointer dereference
	req.Output = a.Output
	    ^
tools/syz-runtest/runtest.go:272:6: SA5011: possible nil pointer dereference
	req.Info = a.Info
	    ^
sys/fuchsia/fidlgen/main.go:27:17: SA5011: possible nil pointer dereference
	arch := target.KernelHeaderArch
	               ^

All these are preceeded with log.Fatalf, which is strange...

Update #2446
dvyukov added a commit that referenced this issue Feb 20, 2021
@dvyukov dvyukov closed this as completed Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant