Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accurate approval check for Rietveld backends #6

Open
nya3jp opened this issue Jul 26, 2016 · 0 comments
Open

Accurate approval check for Rietveld backends #6

nya3jp opened this issue Jul 26, 2016 · 0 comments
Labels
bug

Comments

@nya3jp
Copy link
Contributor

nya3jp commented Jul 26, 2016

Currently changes in Rietveld are considered "approved" when it gets at least one LGTM, but it's not usually sufficient. We may want Chromium-specific approval detection logic.
@nya3jp nya3jp added the bug label Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nya3jp