Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UiObject2#click(Point) API #59

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Support UiObject2#click(Point) API #59

merged 2 commits into from
Nov 8, 2024

Conversation

ko1in1u
Copy link
Collaborator

@ko1in1u ko1in1u commented Nov 8, 2024

This change is Reviewable

@ko1in1u ko1in1u added the enhancement New feature or request label Nov 8, 2024
@ko1in1u ko1in1u added this to the 1.1.3 milestone Nov 8, 2024
@ko1in1u ko1in1u self-assigned this Nov 8, 2024
Copy link
Collaborator

@eric100lin eric100lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ko1in1u)


snippet_uiautomator/uiobject2.py line 44 at r1 (raw file):

  def __call__(
      self,
      timeout: Optional[utils.TimeUnit] = None,

I think we should name it duration instead of timeout to align with the API doc.
Consider to mark timeout as deprecated for backward compatibility and introduce duration.

Code quote:

timeout

@ko1in1u
Copy link
Collaborator Author

ko1in1u commented Nov 8, 2024

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ko1in1u)

snippet_uiautomator/uiobject2.py line 44 at r1 (raw file):

  def __call__(
      self,
      timeout: Optional[utils.TimeUnit] = None,

I think we should name it duration instead of timeout to align with the API doc. Consider to mark timeout as deprecated for backward compatibility and introduce duration.

Code quote:

timeout

Modified accrodingly, thanks!

@ko1in1u ko1in1u merged commit f56307c into google:main Nov 8, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants