Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [REQUEST] - Review and clean up # pylint annotations after migration to ruff #480

Closed
1 task done
lvaylet opened this issue May 30, 2024 · 0 comments · Fixed by #481
Closed
1 task done

💡 [REQUEST] - Review and clean up # pylint annotations after migration to ruff #480

lvaylet opened this issue May 30, 2024 · 0 comments · Fixed by #481
Labels
refactor

Comments

@lvaylet
Copy link
Collaborator

lvaylet commented May 30, 2024

Summary

These annotations might no longer be necessary after the migration to ruff.

Basic Example

Try to remove them all, then run ruff. Finally, restore only the annotations that make sense.

Screenshots

No response

Drawbacks

None. The codebase will be cleaner and more readable.

Unresolved questions

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lvaylet lvaylet linked a pull request May 30, 2024 that will close this issue
chore: review and clean up pylint annotations #481
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: review and clean up pylint annotations google/slo-generator
1 participant
@lvaylet