AMP Auto Ads Compatibility with AMP for WP plugin

[ernee]

When using the AMP for WP plugin on a site implementing AMP Auto Ads, the following validation error is thrown on AMP pages:

The extension ‘amp-auto-ads’ was found on this page, but is unused. Please remove this extension.

AMP auto ads are not implemented/ displayed.

1. Install and activate AMP for WP plugin
2. Visit AMP page (typically/amp endpoint)
3. See the validation error ( in AMP validator or the validation extension)

Screenshots

Additional Context

• PHP Version: 7.1.33
• OS: MacOS
• Browser: Chrome
• Plugin Version: 1.1.3
• Device: MacBook Air

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• In AMP reader mode, the amp-auto-ads component should only be loaded if an amp-auto-ads tag generated by Site Kit is actually present in the post content.

QA Instructions

1. Activate the AMP plugin and set it to Reader mode.
2. With AdSense module set up and it set up to render the tag, ensure the amp-auto-ads tag is still displayed in AMP reader mode content, and that there are no AMP validation errors (i.e. the amp-auto-ads component is also loaded).
3. Add a mini plugin with the following: add_filter( 'the_content', '__return_empty_string', 999 );, which should make every post render with empty content in the frontend. Go back to AMP reader mode content (where the post content should now as well be empty), and ensure that there are no AMP validation errors (i.e. the amp-auto-ads component is not loaded).

Implementation Brief

• In AdSense::amp_data_load_auto_ads_component():
  • If ! $this->adsense_tag_printed, return early.
  • If $data['post_amp_content'] (see https://github.com/ampproject/amp-wp/blob/b86ba30087ea2fcac6f9ddec910fc59428e1ef54/includes/templates/class-amp-post-template.php#L348) does not contain <amp-auto-ads , return early.
• Both of these checks are fine since when setting up all this reader mode data the content (the_content) is generated before the amp_post_template_data filter is run.

Changelog entry

[felixarntz]

@westonruter While this is not related to our AMP plugin, would there be any problem if we simply removed adding amp-auto-ads to amp_component_scripts? Our AMP plugin does that automatically if an amp-auto-ads tag exists in the page right?

[westonruter]

@felixarntz In Standard/Transitional modes, yes. In Reader mode this is only done for components in the post content. However, this is changing in v1.5, in which the entire Reader mode templates are sent through the post-processor (ampproject/amp-wp#2202). So as of v1.5, filtering amp_component_scripts will be truly a thing of the past in the AMP plugin.

[TB7722]

@felixarntz What is the targeted release date for this. Thanks

[felixarntz]

@TB7722 We don't have a clear timeline yet, but this might make it into the next release scheduled for in 3 weeks from now.

[aaemnnosttv]

@felixarntz as long as the implementation is the same across all AMP modes, ✅ IB

[demiromer]

Hi is there any workaround about this?
Google stop indexing amp pages due to validation error

[jamesozzie]

@ernee While I can't reproduce this validation error I can see the fallback hook is used in the AMP for WP templates to place the Site Kit Auto ads for AMP code. Maybe we can take a look at this later if you're free.

The image below shows the code placements on AMP for WP (via Site Kit).

@demiromer Can you share your site URL and I can see if I notice anything in relation to those errors?

[demiromer]

Its been over a month @jamesozzie and I have already replaced the plugin

[ernee]

@jamesozzie as discussed, I no longer get the error as well. I suspect the AMP for WP plugin has added compatibility in version 1.0.7 per their changelog.

[ryanwelcher]

I am unable to reproduce this either.

[tofumatt]

If QA can't reproduce this either I think we can safely close it as fixed upstream 👍

[cole10up]

I'm unable to reproduce this one on my end. Looks to be fixed.

Passed QA ✅

[ernee]

Closing as it was not reproducible any longer.