Excluding all logged in users from Analytics results in invalid JSON in Web Stories preview debug mode

[LuckynaSan]

Bug Description

1.) When you enable the option to exclude all logged in users from Analytics in Site Kit by Google, Story passes AMP validator, but Story's debug mode in the story preview is outputting the below warning

Steps to reproduce

1. Go to Site Kit settings
2. Click on edit Analytics > Exclude from Analytics all logged-in users
3. Go to Web Stories
4. Open in editor > preview a story
5. See debug tab and notice invalid JSON error

Screenshots

Additional Context

Related Github issue GoogleForCreators/web-stories-wp#7939

• PHP Version:
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari] chrome
• Plugin Version [e.g. 22] 1.34.0
• Device: [e.g. iPhone6] macOS

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The GA opt-out element output for AMP should not raise any validation errors or warnings for HTML or AMP markup validation

Implementation Brief

• Merge Change AMP GA opt-out to use meta tag #3593.
  See conversation on Preview development mode warns on invalid JSON if excluding all logged in users from Analytics GoogleForCreators/web-stories-wp#7939 issue for more information

Test Coverage

• No changes

Visual Regression Changes

• N/A

QA Brief

• Set up and configure Analytics to exclude tracking for logged in users (default)
• Enable Web Stories and create a new story
• Leave blank and click Preview
• On the preview screen, click the Debug tab
• Review the results, ensure the __gaOptOutExtension element is not reported (there may be other validation errors/warnings not from Site Kit)

Changelog entry

• Fix AMP validation error caused by the GA opt-out snippet conditionally placed by Site Kit.

[felixarntz]

IB / CR ✅

[felixarntz]

@eclarke1 @fhollis Adding this to Sprint 51 since it was a quick fix.

[wpdarren]

@aaemnnosttv I am seeing the same error and tested this on two different sites. Would you be able to check that it has successfully merged, and if you still see the errors or not?

[aaemnnosttv]

@wpdarren the problem is that Site Kit isn't setting the proper AMP mode when Web Stories is active. This should be fixed in #2998 but there is a problem with the implementation there which I will follow up on now.

[aaemnnosttv]

@wpdarren actually, sorry, it should be good – I just tested this again and while there are errors that show Site Kit, it's mostly because the output is minified and line 6 starts with our opt-out comment there which is normal. The main error we don't want to see is the first one in your screenshot there about invalid JSON.

Here's what I see

[wpdarren]

QA Update: Pass ✅

• The invalid JSON is not reported as per the QAB.