From edf66b83e3325edf1db24997ebceed7562822bdd Mon Sep 17 00:00:00 2001 From: Russell Hancox Date: Wed, 15 May 2024 13:08:36 -0400 Subject: [PATCH] Project: Re-enable layering_checks --- BUILD | 4 ---- Source/common/BUILD | 1 - Source/gui/BUILD | 1 - Source/santabundleservice/BUILD | 1 - Source/santactl/BUILD | 1 - Source/santad/BUILD | 1 - Source/santad/Logs/EndpointSecurity/Writers/FSSpool/BUILD | 1 - Source/santad/ProcessTree/BUILD | 1 - Source/santad/ProcessTree/annotations/BUILD | 1 - Source/santametricservice/BUILD | 1 - Source/santametricservice/Formats/BUILD | 1 - Source/santametricservice/Writers/BUILD | 1 - Source/santasyncservice/BUILD | 1 - Testing/integration/BUILD | 1 - Testing/integration/VM/Common/BUILD | 1 - external_patches/OCMock/BUILD | 1 - external_patches/moroz/BUILD | 1 - profiles/BUILD | 1 - 18 files changed, 21 deletions(-) diff --git a/BUILD b/BUILD index 73a268f89..9e96c9eb3 100644 --- a/BUILD +++ b/BUILD @@ -3,10 +3,6 @@ load("//:helper.bzl", "run_command") package( default_visibility = ["//:santa_package_group"], - # NOTE: layering_check is disabled in all Santa BUILD files because the feature - # works inconsistently between versions of bazel in a way that causes problems - # when pulling the GitHub source into the internal source tree for building. - features = ["-layering_check"], ) licenses(["notice"]) diff --git a/Source/common/BUILD b/Source/common/BUILD index 970bbcd0f..8b4911a86 100644 --- a/Source/common/BUILD +++ b/Source/common/BUILD @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test") package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) licenses(["notice"]) diff --git a/Source/gui/BUILD b/Source/gui/BUILD index 061a82287..7c7dd00a1 100644 --- a/Source/gui/BUILD +++ b/Source/gui/BUILD @@ -6,7 +6,6 @@ licenses(["notice"]) package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) exports_files([ diff --git a/Source/santabundleservice/BUILD b/Source/santabundleservice/BUILD index bc0ddca8b..9b209ae16 100644 --- a/Source/santabundleservice/BUILD +++ b/Source/santabundleservice/BUILD @@ -4,7 +4,6 @@ licenses(["notice"]) package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) objc_library( diff --git a/Source/santactl/BUILD b/Source/santactl/BUILD index e0d033765..2632b3887 100644 --- a/Source/santactl/BUILD +++ b/Source/santactl/BUILD @@ -5,7 +5,6 @@ licenses(["notice"]) package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) objc_library( diff --git a/Source/santad/BUILD b/Source/santad/BUILD index df3450241..d0d73b7dc 100644 --- a/Source/santad/BUILD +++ b/Source/santad/BUILD @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test") package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) licenses(["notice"]) diff --git a/Source/santad/Logs/EndpointSecurity/Writers/FSSpool/BUILD b/Source/santad/Logs/EndpointSecurity/Writers/FSSpool/BUILD index 089cf2b6a..e7cbe5d2e 100644 --- a/Source/santad/Logs/EndpointSecurity/Writers/FSSpool/BUILD +++ b/Source/santad/Logs/EndpointSecurity/Writers/FSSpool/BUILD @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test") package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) proto_library( diff --git a/Source/santad/ProcessTree/BUILD b/Source/santad/ProcessTree/BUILD index ad048159a..add141c13 100644 --- a/Source/santad/ProcessTree/BUILD +++ b/Source/santad/ProcessTree/BUILD @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test") package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) cc_library( diff --git a/Source/santad/ProcessTree/annotations/BUILD b/Source/santad/ProcessTree/annotations/BUILD index a2647e348..a10fd7ac2 100644 --- a/Source/santad/ProcessTree/annotations/BUILD +++ b/Source/santad/ProcessTree/annotations/BUILD @@ -2,7 +2,6 @@ load("//:helper.bzl", "santa_unit_test") package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) cc_library( diff --git a/Source/santametricservice/BUILD b/Source/santametricservice/BUILD index ec7d82177..36f5a80b3 100644 --- a/Source/santametricservice/BUILD +++ b/Source/santametricservice/BUILD @@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test") package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) licenses(["notice"]) diff --git a/Source/santametricservice/Formats/BUILD b/Source/santametricservice/Formats/BUILD index 6e25e1e76..59ff61da9 100644 --- a/Source/santametricservice/Formats/BUILD +++ b/Source/santametricservice/Formats/BUILD @@ -2,7 +2,6 @@ load("//:helper.bzl", "santa_unit_test") package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) licenses(["notice"]) diff --git a/Source/santametricservice/Writers/BUILD b/Source/santametricservice/Writers/BUILD index 7c8ba270d..b04a0ae24 100644 --- a/Source/santametricservice/Writers/BUILD +++ b/Source/santametricservice/Writers/BUILD @@ -2,7 +2,6 @@ load("//:helper.bzl", "santa_unit_test") package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) licenses(["notice"]) diff --git a/Source/santasyncservice/BUILD b/Source/santasyncservice/BUILD index ca40c8406..8412ef49f 100644 --- a/Source/santasyncservice/BUILD +++ b/Source/santasyncservice/BUILD @@ -5,7 +5,6 @@ licenses(["notice"]) package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) objc_library( diff --git a/Testing/integration/BUILD b/Testing/integration/BUILD index 3f7ec8fe4..4bb317d7a 100644 --- a/Testing/integration/BUILD +++ b/Testing/integration/BUILD @@ -2,7 +2,6 @@ load("//:helper.bzl", "run_command", "santa_unit_test") package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) licenses(["notice"]) diff --git a/Testing/integration/VM/Common/BUILD b/Testing/integration/VM/Common/BUILD index 49c60b2e0..66aeb3f52 100644 --- a/Testing/integration/VM/Common/BUILD +++ b/Testing/integration/VM/Common/BUILD @@ -2,7 +2,6 @@ package( default_visibility = [ "//Testing/integration/VM:__subpackages__", ], - features = ["-layering_check"], ) objc_library( diff --git a/external_patches/OCMock/BUILD b/external_patches/OCMock/BUILD index e8393cb2f..d12c00360 100644 --- a/external_patches/OCMock/BUILD +++ b/external_patches/OCMock/BUILD @@ -2,5 +2,4 @@ licenses(["notice"]) package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) diff --git a/external_patches/moroz/BUILD b/external_patches/moroz/BUILD index e8393cb2f..d12c00360 100644 --- a/external_patches/moroz/BUILD +++ b/external_patches/moroz/BUILD @@ -2,5 +2,4 @@ licenses(["notice"]) package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) diff --git a/profiles/BUILD b/profiles/BUILD index da7a526c6..179073a5c 100644 --- a/profiles/BUILD +++ b/profiles/BUILD @@ -1,6 +1,5 @@ package( default_visibility = ["//:santa_package_group"], - features = ["-layering_check"], ) licenses(["notice"])