From 50879815588a5da63dbb67e1b59e92040e464454 Mon Sep 17 00:00:00 2001 From: Jirka Date: Mon, 11 Mar 2024 21:23:27 +0100 Subject: [PATCH 1/4] ci: expand build matrix for major OS --- .github/workflows/build.yml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index eb510f03..560b5eea 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -2,12 +2,22 @@ name: Python Fire on: [push] +defaults: + run: + shell: bash + jobs: build: - runs-on: ubuntu-20.04 + runs-on: ${{ matrix.os }} strategy: matrix: - python-version: ["3.5", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12"] + fail-fast: false + os: ["ubuntu-latest", "macos-latest", "windows-latest"] + python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] + include: + # adding some specific/older versions to the matrix + - {os: "ubuntu-20.04", python-version: "3.5"} + - {os: "ubuntu-20.04", python-version: "3.7"} steps: # Checkout the repo. @@ -22,7 +32,6 @@ jobs: # Build Python Fire using the build.sh script. - name: Run build script - shell: bash run: ./.github/scripts/build.sh env: PYTHON_VERSION: ${{ matrix.python-version }} From caadb03252511ee90c898a469f017b5b84522ed5 Mon Sep 17 00:00:00 2001 From: Jirka Borovec <6035284+Borda@users.noreply.github.com> Date: Mon, 11 Mar 2024 22:32:06 +0100 Subject: [PATCH 2/4] reoder OS Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 560b5eea..00c2b81c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -12,7 +12,7 @@ jobs: strategy: matrix: fail-fast: false - os: ["ubuntu-latest", "macos-latest", "windows-latest"] + os: ["windows-latest", "macos-latest", "ubuntu-latest"] python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] include: # adding some specific/older versions to the matrix From a4100e29d549a943a77eac8efbdf8dc092020a4a Mon Sep 17 00:00:00 2001 From: Jirka Borovec <6035284+Borda@users.noreply.github.com> Date: Sat, 21 Sep 2024 20:59:43 +0200 Subject: [PATCH 3/4] Fail fast --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ef5befa4..dd77dfd9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,6 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - fail-fast: false os: ["windows-latest", "macos-latest", "ubuntu-latest"] python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13.0-rc.2"] include: From 4fdfc376891c4a457fb6a5c479dd0cde2b537acc Mon Sep 17 00:00:00 2001 From: Jirka Borovec <6035284+Borda@users.noreply.github.com> Date: Sat, 21 Sep 2024 23:23:54 +0200 Subject: [PATCH 4/4] Apply suggestions from code review --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index dd77dfd9..59b0a4ba 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: ["windows-latest", "macos-latest", "ubuntu-latest"] + os: ["macos-latest", "ubuntu-latest"] python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13.0-rc.2"] include: - {os: "ubuntu-20.04", python-version: "3.7"}