From 7862a9d3192995e046455e16d525d56af03a389d Mon Sep 17 00:00:00 2001 From: Frederic Branczyk Date: Wed, 24 Jul 2024 08:11:24 +0200 Subject: [PATCH] proto: Add comment on location address adjustment This comment reflects how the pprof toolchain already treats this case, so this change is primarily to signify that it is the expected behavior from consumers. --- proto/profile.proto | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/proto/profile.proto b/proto/profile.proto index ff987a61..a4520286 100644 --- a/proto/profile.proto +++ b/proto/profile.proto @@ -186,6 +186,10 @@ message Location { // for the corresponding mapping. A non-leaf address may be in the // middle of a call instruction. It is up to display tools to find // the beginning of the instruction if necessary. + // If Mapping.memory_start is 0, Mapping.memory_limit is 0 or the max uint64, + // and Mapping.file_offset is 0, then the location is already fully adjusted + // to the symbol table address space, and display tools should not attempt to + // further adjust it. uint64 address = 3; // Multiple line indicates this location has inlined functions, // where the last entry represents the caller into which the