Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for llvm-gsymutil #632

Closed
sfc-gh-sgiesecke opened this issue May 12, 2021 · 1 comment · May be fixed by #636
Closed

Add support for llvm-gsymutil #632

sfc-gh-sgiesecke opened this issue May 12, 2021 · 1 comment · May be fixed by #636

Comments

@sfc-gh-sgiesecke
Copy link

Symbolication is supported through addr2line, llvm-symbolizer and nm right now. When GSYM data is available for a binary, using llvm-gsymutil would be much faster and less memory-intensive than addr2line or llvm-symbolizer.

To make this fit in well with the execution model of pprof, it requires an extension of llvm-gsymutil to allow it to be fed the input addresses from stdin, as suggested by https://reviews.llvm.org/D102224
sfc-gh-sgiesecke added a commit to sfc-gh-sgiesecke/pprof that referenced this issue May 12, 2021
@sfc-gh-sgiesecke
Add GSYM support.
4d86455 
Fixes google#632
sfc-gh-sgiesecke added a commit to sfc-gh-sgiesecke/pprof that referenced this issue Jun 17, 2021
@sfc-gh-sgiesecke
Add GSYM support.
609c4a4 
Fixes google#632
@sfc-gh-sgiesecke sfc-gh-sgiesecke mentioned this issue Jun 17, 2021
Draft
@nolanmar511
Copy link
Contributor

Per discussion in #636, this is something we don't think makes sense to support directly within pprof at this time.

Marking as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add gsym support sfc-gh-sgiesecke/pprof
2 participants
@nolanmar511 @sfc-gh-sgiesecke