From 2f9247f0fb145e3e26a3fc2fea383a17b993841f Mon Sep 17 00:00:00 2001
From: Wyatt Hepler <hepler@google.com>
Date: Thu, 9 Jun 2022 15:50:23 -0700
Subject: [PATCH] pw_rpc: Remove the default abandon() implementation

This reverts commit c294be0b0ac9f3dde0aaeec38436acead10d4f52, which was
a temporary workaround.

Change-Id: I865a6c7d67bc8803ad3f0e8b5e4d73b38a5d46ee
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/97747
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Alexei Frolov <frolv@google.com>
---
 pw_rpc/java/main/dev/pigweed/pw_rpc/Call.java | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/pw_rpc/java/main/dev/pigweed/pw_rpc/Call.java b/pw_rpc/java/main/dev/pigweed/pw_rpc/Call.java
index 4e08261503..17ef0949a5 100644
--- a/pw_rpc/java/main/dev/pigweed/pw_rpc/Call.java
+++ b/pw_rpc/java/main/dev/pigweed/pw_rpc/Call.java
@@ -24,16 +24,7 @@ public interface Call {
   void cancel() throws ChannelOutputException;
 
   /** Cancels the RPC as in cancel(), but does not send a cancellation packet to the server. */
-  default void abandon() {
-    // By default, call cancel() and ignore exceptions.
-    // TODO(b/235513314): Remove this default implementation once users have
-    //     implemented abandon().
-    try {
-      cancel();
-    } catch (ChannelOutputException e) {
-      // Ignore the exception, since abandon() isn't supposed to send packets.
-    }
-  }
+  void abandon();
 
   /** True if the RPC has not yet completed. */
   default boolean active() {