From 29fc404197899dd272320c336f944b91e2140f09 Mon Sep 17 00:00:00 2001
From: Ted Pudlik <tpudlik@google.com>
Date: Mon, 7 Oct 2024 18:31:18 +0000
Subject: [PATCH] Revert "pw_system: Don't use implementation_deps"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This reverts commit 65c56255b82a13cc2b521b12cedf165b696261b5.

Reason for revert: Implementation deps now supported internally.

Original change's description:
> pw_system: Don't use implementation_deps
>
> This is just a temporary mitigation for a lack of support for
> implementation_deps internally. I hope to revert this within weeks.
>
> Bug: 304374970
> Bug: 356667663
> Change-Id: I16cc22c36960cb53676591709f5402f2a8032370
> Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/226977
> Pigweed-Auto-Submit: Ted Pudlik <tpudlik@google.com>
> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
> Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
> Reviewed-by: Armando Montanez <amontanez@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 304374970
Bug: 356667663
Change-Id: Ie51d90b1e29a8244bd60390e8fb5e6fb52e84e8c
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/227601
Reviewed-by: Armando Montanez <amontanez@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Ted Pudlik <tpudlik@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
---
 pw_system/BUILD.bazel | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/pw_system/BUILD.bazel b/pw_system/BUILD.bazel
index af9dc78d83..66af71bae9 100644
--- a/pw_system/BUILD.bazel
+++ b/pw_system/BUILD.bazel
@@ -562,8 +562,7 @@ cc_library(
         "threads.cc",
     ],
     hdrs = ["public/pw_system/system.h"],
-    includes = ["public"],
-    deps = [
+    implementation_deps = [
         ":async_packet_io",
         ":device_service",
         ":file_manager",
@@ -572,16 +571,12 @@ cc_library(
         ":thread_snapshot_service",
         ":transfer_service",
         ":work_queue",
-        "//pw_allocator:allocator",
         "//pw_allocator:best_fit_block_allocator",
         "//pw_allocator:synchronized_allocator",
         "//pw_async2:allocate_task",
-        "//pw_async2:dispatcher",
         "//pw_async2:pend_func_task",
-        "//pw_channel",
         "//pw_hdlc:router",
         "//pw_multibuf:simple_allocator",
-        "//pw_rpc",
         "//pw_rpc/pwpb:echo_service",
         "//pw_sync:interrupt_spin_lock",
         "//pw_thread:thread",
@@ -592,6 +587,13 @@ cc_library(
         ],
         "//conditions:default": [],
     }),
+    includes = ["public"],
+    deps = [
+        "//pw_allocator:allocator",
+        "//pw_async2:dispatcher",
+        "//pw_channel",
+        "//pw_rpc",
+    ],
 )
 
 cc_library(