You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, our git commit enumeration relies on the commit hashes listed in the OSV record (as introduced/fixed/last_affected) to exist in git branches in the upstream repository:
This assumption doesn't hold in a number of cases. e.g. #2333 and #2375 (comment) to name a few.
We need to relax this requirement to instead:
Consider the referenced introduced/fixed/last_affected commit position as its own logical "branch" if it's not part of any upstream branches.
Include all tag references that isn't already covered by a branch in the analysis. This is likely less important than 1, which would solve most of the problems we've seen.
The text was updated successfully, but these errors were encountered:
oliverchang
added
backlog
Important but currently unprioritized
and removed
stale
The issue or PR is stale and pending automated closure
labels
Sep 20, 2024
Currently, our git commit enumeration relies on the commit hashes listed in the OSV record (as introduced/fixed/last_affected) to exist in git branches in the upstream repository:
osv.dev/osv/impact.py
Line 168 in a751ceb
osv.dev/osv/impact.py
Line 172 in a751ceb
This assumption doesn't hold in a number of cases. e.g. #2333 and #2375 (comment) to name a few.
We need to relax this requirement to instead:
The text was updated successfully, but these errors were encountered: