-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License should be marked as violated only in case there is no other allowed license #949
Comments
I made some thinking and I'm not sure deps.dev can tell the difference between choice-of-license(when you can choose which license to comply) and multi-license(when you need to comply both licenses). Any idea? |
CC @josieang who is from deps.dev and contributed this feature. |
Hi @shahar-h, deps.dev developer here. There are two ecosystems for which deps.dev serves multiple licenses for a single package version when available: Go and Maven. For Maven, it is usually (but not always!) the case that multiple licenses should be joined with an implicit "OR" (this is the documented meaning, but in practice it's clear that this isn't universally accepted). For Go, multiple licenses should usually (but–again–not always!) be joined with an implicit "AND". Because we don't want to make guesses about licensing, we err on the side of caution and simply present multiple licenses as a list, for the user to interpret or investigate further if needed. Do note that, for all systems, the package author could (and should!) use an SPDX expression like For more information about how deps.dev determines licenses, please see our FAQ. |
Thank you! |
When scanning a package which declares more than one license (e.g. go-metrics which declares both
Apache-2.0
andCC-BY-SA-4.0
licenses), a license should be marked as violated only in case there is no other allowed license. Currently when scanning the above package for license violations (osv-scanner --experimental-licenses="Apache-2.0"
) a license violation appears for above package although it also declaresApache-2.0
license which is in our allow list.In case you agree that this is a bug I can contribute a fix.
The text was updated successfully, but these errors were encountered: