Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Pipenv develop packages without versions. #297

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

spencerschrock
Copy link
Contributor

This extracts the shared detail parsing between default and develop packages.

Resolves #296

This extracts the shared detail parsing between default and develop packages.

Signed-off-by: Spencer Schrock <[email protected]>
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@spencerschrock
Copy link
Contributor Author

Note this can still panic if the version is pipenvPackage.Version has length 1, but that seems to be an invalid Pipfile.lock

Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear I already handled this, but maybe I never got around to it 🤔

@oliverchang oliverchang merged commit c147987 into google:main Mar 14, 2023
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
This extracts the shared detail parsing between default and develop
packages.

Resolves google#296

Signed-off-by: Spencer Schrock <[email protected]>
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
This extracts the shared detail parsing between default and develop
packages.

Resolves google#296

Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock spencerschrock deleted the bug/pipenv-lock-panic branch November 10, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic while parsing Pipenv lockfile
4 participants