Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Action] Call analysis doesn't work for go projects with go version > 1.22.8 #1453

Closed
shahar-h opened this issue Dec 17, 2024 · 2 comments · May be fixed by envoyproxy/gateway#4956
Closed
Labels
backlog Important but currently unprioritized enhancement New feature or request

Comments

@shahar-h
Copy link

shahar-h commented Dec 17, 2024

Currently call analysis doesn't work for go projects with go version > 1.22.8, which is the go version of the latest osv-scanner-action image (v1.9.1).
When a new vulnerability is detected call analysis fails with:

Failed to run code analysis (govulncheck) on '/app/tools/src/buf/go.mod' because govulncheck: loading packages: err: exit status 1: stderr: go: go.mod requires go >= 1.23.3 (running go 1.22.8; GOTOOLCHAIN=local)

(the Go toolchain is required)

I suggest one of the following:

  1. Release a new osv-scanner version and osv-scanner-action version when a new golang version is available. Currently there is an open PR with alpine based image update, which also updates go version to latest.
  2. Add support in github action to install and run osv-scanner on machine instead of inside container, thus allowing the consumer to install go itself, similar to golangci-lint-action.

Can you please merge the PR for now and release a new version?

@another-rex another-rex added enhancement New feature or request backlog Important but currently unprioritized labels Dec 17, 2024
@another-rex
Copy link
Collaborator

Good idea to support using the host osv-scanner rather than fully relying on a containerised version. We'll release a new version of osv-scanner soon to fix the govulncheck issue as well.

@hogo6002
Copy link
Contributor

hogo6002 commented Dec 19, 2024

We have made a fix release for this issue: https://github.com/google/osv-scanner-action/releases/tag/v1.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Important but currently unprioritized enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants