Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out unimportant vulnerabilities from vuln group #1072

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

hogo6002
Copy link
Contributor

#968 only filters out unimportant vulnerabilities from pkgVulns.Vulnerabilities but not from pkgVulns.Groups. This causes some unimportant vulnerabilities to still appear in the scanner output.
Fixing this issue by ignoring all unimportant vulnerability groups.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.35%. Comparing base (fdca369) to head (e6b1130).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   65.34%   65.35%           
=======================================
  Files         150      150           
  Lines       12529    12535    +6     
=======================================
+ Hits         8187     8192    +5     
- Misses       3882     3883    +1     
  Partials      460      460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hogo6002 hogo6002 merged commit 4fa2fa4 into google:main Jun 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants