[elfutils] point CIFuzz to evverx/elfutils #6967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created https://github.com/evverx/elfutils where I test elfutils with gcc/clang, asan/ubsan, LGTM and Coverity. It would be great if it was possible to test patches with CIFuzz there as well. Judging by https://github.com/evverx/elfutils/actions/runs/1527662451, it just falls back to the official repository (which is hosted at https://sourceware.org/git/?p=elfutils.git;a=summary and where GitHub branches CIFuzz tries to checkout don't exist) ``` Stderr of command "git fetch origin refs/pull/2/merge" is: fatal: couldn't find remote ref refs/pull/2/merge Can not check out requested state refs/pull/2/merge. Using current repo state ``` It would be even better if instead of hardcoding "evverx/elfutils" I could pass `${{ github.repository }}` or something like that. More generally, this PR is an attempt to get around google#3731
evverx
commented
Dec 4, 2021
| @@ -17,6 +17,11 @@ | |||
| FROM gcr.io/oss-fuzz-base/base-builder | |||
| RUN apt-get update && \ | |||
| apt-get install -y pkg-config make autoconf autopoint zlib1g-dev flex bison gawk | |||
| RUN git clone --depth 1 git://sourceware.org/git/elfutils.git | |||
| RUN bash -x -c "\ | |||
| if [[ '$CIFUZZ' == True ]]; then \ | |||
There was a problem hiding this comment.
FWIW I'm not sure why the skia project started to use true (instead of True) in https://github.com/google/oss-fuzz/pull/4588/files. As far as I can see the variable is always set to True on CIFuzz
|
The CI seems to have failed due to #6957. Looks like the base builder image hasn't been rebuilt yet |
|
Closing in favor of evverx/elfutils#35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created https://github.com/evverx/elfutils where I test elfutils
with gcc/clang, asan/ubsan, LGTM and Coverity. It would be great
if it was possible to test patches with CIFuzz there as well. Judging by
https://github.com/evverx/elfutils/actions/runs/1527662451, it just
falls back to the official repository (which is hosted at https://sourceware.org/git/?p=elfutils.git;a=summary
and where GitHub branches CIFuzz tries to checkout don't exist)
It would be even better if instead of hardcoding "evverx/elfutils"
I could pass
${{ github.repository }}or something like that.More generally, this PR is an attempt to get around #3731