Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-tools: Add fuzz target for spirv-fuzz #6689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

spirv-tools: Add fuzz target for spirv-fuzz #6689

wants to merge 2 commits into from

Conversation

afd
Copy link
Contributor

@afd afd commented Oct 29, 2021

Adds a fuzz target to test the spirv-fuzz testing tool.

jonathanmetzman
jonathanmetzman approved these changes Oct 31, 2021
View reviewed changes
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we need to fix some errors before merging this.

@jonathanmetzman jonathanmetzman enabled auto-merge (squash) October 31, 2021 12:40
@afd
Copy link
Contributor Author

afd commented Oct 31, 2021

Would you mind running the CI again please @jonathanmetzman ? I landed a PR in the upstream project which fixes some compiler warnings the OSS-Fuzz build was treating as errors.

@jonathanmetzman
Copy link
Contributor

Running again.

@jonathanmetzman
Copy link
Contributor

Do we still want this PR?
Should I just merge it?

@afd
Copy link
Contributor Author

afd commented Dec 7, 2021

We do want the PR, but let me take another look at it before we merge.

@jonathanmetzman
Copy link
Contributor

It looks the coverage failure is just a linker issue that we can ignore for now. CI will fail but that's fine I guess.

@jonathanmetzman
Copy link
Contributor

spirv-tools also fixed

@afd
Copy link
Contributor Author

afd commented Dec 7, 2021

Many thanks!

@jonathanmetzman
Copy link
Contributor

Many thanks!

Np. I posted the fixed comment in the wrong issue. I meant to post it in #6978

@afd
spirv-tools: Add fuzz target for spirv-fuzz
cab5214 
Adds a fuzz target to test the spirv-fuzz testing tool.
auto-merge was automatically disabled January 4, 2022 15:11

Head branch was pushed to by a user without write access

@afd
Copy link
Contributor Author

afd commented Jan 4, 2022

@jonathanmetzman Any idea why there's a failing linker command in the coverage build? I suppose it's a memout or timeout or something?

I could add some logic to the build script to stop spirv-fuzz being built with coverage during CI, I suppose.

@maflcko
Copy link
Contributor

maflcko commented Apr 2, 2024

Needs CI re-run, if still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afd @jonathanmetzman @maflcko