Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable thread safety analysis checks for connectedhomeip #10279

Merged

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented May 9, 2023

This fixes compilation errors of the form:

...
Step #3 - "compile-centipede-address-x86_64": �[1m../../src/platform/Linux/ConnectivityManagerImpl.h:211:46: �[0m�[0;1;31merror: �[0m�[1m'guarded_by' attribute requires arguments whose type is annotated with 'capability' attribute; type here is 'std::mutex' [-Werror,-Wthread-safety-attributes]�[0m
Step #3 - "compile-centipede-address-x86_64":     static GDBusWpaSupplicant mWpaSupplicant CHIP_GUARDED_BY(mWpaSupplicantMutex);
Step #3 - "compile-centipede-address-x86_64": �[0;1;32m                                             ^
Step #3 - "compile-centipede-address-x86_64": �[0m�[1m../../src/system/SystemMutex.h:75:49: �[0m�[0;1;30mnote: �[0mexpanded from macro 'CHIP_GUARDED_BY'�[0m
Step #3 - "compile-centipede-address-x86_64": #define CHIP_GUARDED_BY(x) CHIP_TSA_ATTRIBUTE__(guarded_by(x))
Step #3 - "compile-centipede-address-x86_64": �[0;1;32m                                                ^
Step #3 - "compile-centipede-address-x86_64": �[0m1 error generated.

as reported in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=58531

Also updated the dockerfile to checkout less things from CHIP so that the checkout step is faster.

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman jonathanmetzman merged commit ef79baa into google:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants