Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a way to turn fuzz-introspector off #7591

Closed
evverx opened this issue Apr 20, 2022 · 6 comments
Closed

There should be a way to turn fuzz-introspector off #7591

evverx opened this issue Apr 20, 2022 · 6 comments

Comments

@evverx
Copy link
Contributor

evverx commented Apr 20, 2022

As far as I understand fuzz-introspector is a work in progress and build failures aren't reported on Monorail and badges don't turn yellow/red so it doesn't affect projects where it isn't supported or actively maintained. Once it's rolled out globally I think it should be possible to turn it off because I think kludges like #7583 (comment) aren't exactly robust and it isn't clear how long it will take to fix them when they stop working suddenly.

@jonathanmetzman
Copy link
Contributor

Agreed. @Navidem @oliverchang WDYT?

IMO fuzz introspector is qualitatively different from fuzzing and maybe even coverage. In a somewhat ideal, but not perfect world OSS-Fuzz shouldn't bother users about it unless they opt-in (the perfect scenario is opt-out but nothing ever breaks :-)

@Navidem
Copy link
Contributor

Navidem commented Apr 20, 2022

Thanks @evverx for pointing this out.
Currently the introspector builds use separate images so changes like those mentioned in #7583 should not affect fuzzing or coverage builds at all. That said, I agree we can provide options to opt-out the project.

@evverx
Copy link
Contributor Author

evverx commented Apr 20, 2022

I think it would be better to opt-in. As far as I understand for example due to separate images it's difficult to integrate it into the OSS-Fuzz CI so when projects are integrated they can't be sure whether they are buildable with fuzz-introspector or not. I suspect it's also hard to test it locally or on GitHub using GHActions like CIFuzz so any change can break it. Though I agree as long as it doesn't affect anything it should be turned on by default to make it easier to test it.

@oliverchang
Copy link
Collaborator

We don't plan to turn on automated build notifications or change badge colours for fuzz introspector builds for the time being. Longer term we need to figure out a solution to minimise environment differences, but having the automatic builds is desirable for testing.

@oliverchang
Copy link
Collaborator

Closing since it seems there are no further objections to this?

@evverx
Copy link
Contributor Author

evverx commented May 23, 2022

I still think it should be possible to turn it off somehow eventually using project.yaml but systemd/systemd@ebd4541 should suffice for the time being probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants