Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests when building base-images #526

Closed
oliverchang opened this issue Apr 7, 2017 · 3 comments
Closed

Run tests when building base-images #526

oliverchang opened this issue Apr 7, 2017 · 3 comments
Assignees
@Dor1s
Labels
infrastructure priority

Comments

@oliverchang
Copy link
Collaborator

We want to prevent things like 49baa72 from happening again.
@oliverchang oliverchang mentioned this issue Apr 7, 2017
Closed
@oliverchang oliverchang self-assigned this Apr 17, 2017
@oliverchang oliverchang mentioned this issue May 31, 2017
Closed
@inferno-chromium inferno-chromium assigned Dor1s and unassigned oliverchang Jun 1, 2017
@inferno-chromium
Copy link
Collaborator

We should still run tests even after we are using pinned chromium revision. The reason being we are running on tip-of-tree libFuzzer and that can still break. Assigning to Max.

@inferno-chromium
Copy link
Collaborator

I think @Dor1s bad build checks will catch this. @oliverchang - do you think we need to run all llvm test here or bad build check is a reasonable stopgap ? if yes, please close.

@oliverchang
Copy link
Collaborator Author

I think the bad build checks are a reasonable stopgap. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dor1s Dor1s

Labels
infrastructure priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliverchang @Dor1s @inferno-chromium