Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skia: UBSan build is crashing on seed corpus #1364

Closed
Dor1s opened this issue Apr 27, 2018 · 6 comments
Closed

skia: UBSan build is crashing on seed corpus #1364

Dor1s opened this issue Apr 27, 2018 · 6 comments

Comments

@Dor1s
Copy link
Contributor

Dor1s commented Apr 27, 2018

https://oss-fuzz-build-logs.storage.googleapis.com/index.html

5 fuzz targets are considered broken as they crash when running on a seed corpus without any mutations.

//cc @kjlubick

@kjlubick
Copy link
Contributor

Is this new? Can we opt out?

@inferno-chromium
Copy link
Collaborator

@kjlubick - yes that check is a little noisy without auto-bug creation (esp here vs monorail). we are disabling the check now.

@Dor1s
Copy link
Contributor Author

Dor1s commented Apr 27, 2018

Yes, the post-build check is new, but the idea is not, as it matches requirements of Ideal Integration Guide. There is no way to opt out. Fuzz targets that crash on seed corpus are considered broken and not useful until those crashes get fixed. If we upload and run such targets, we'd simply waste CPUs while crashing on corpus again and again.

However, we've temporarily disabled that check until we implement bug auto-filing for broken builds.

@kjlubick
Copy link
Contributor

Thanks - will the autobug give a list of bad inputs to make it easy to remove from the corpus? Or will there be a script I can run locally to double check the seed corpus is clean?

@Dor1s
Copy link
Contributor Author

Dor1s commented Apr 27, 2018

Removing inputs from the corpus is a wrong way to fix this :)

But yes there will be a way to reproduce that locally: #1356

@inferno-chromium
Copy link
Collaborator

No need to track here, you should see a bug filed with title ": Build failure" in monorail tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants