Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS REGRESSION: Apple Pay banner fails to render when opening AR QuickLook with USDZ blob #4770

Open
3 of 13 tasks
milesgreen opened this issue May 5, 2024 · 3 comments
Open
3 of 13 tasks
Labels
flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue

Comments

@milesgreen
Copy link
Contributor

Description

Hi @AdaRoseCannon - another iOS regression for you ❤️

As discussed here:
#3425 (comment)

Reported on WebKit Bugzilla:
https://bugs.webkit.org/show_bug.cgi?id=271701

Also reported via Feedback Assistant (FB13779595)


In iOS 17, when opening a USDZ blob to view in AR QuickLook, and passing in Apple Pay # params, such as applePayButtonType / checkoutTitle / checkoutSubtitle / price, the Apple Pay banner is not displayed.

In previous versions of iOS, this used to be possible.

When opening USDZ blob, it is still possible to use other # params such as allowsContentScaling / canonicalWebPageURL and most significantly, custom / customHeight parameters to render a custom banner in the ARQL session.

Also, when using a USDZ file rather than blob, the Apple Pay banner params do work and banner is displayed.

Repro steps:

  • Using iOS 17 iPhone
  • Visit this test: https://modelviewer-extended-params.glitch.me/
  • Turn ON 'Auto USDZ' option to use USDZ blob rather than the USDZ file.
  • Turn ON 'QuickLook Apple Pay Button' option to add applePayButtonType / checkoutTitle / checkoutSubtitle / price # params.
  • Tap the AR icon to open model in AR QuickLook.
  • Observe, no Apple Pay banner.

Tested with:

  • iOS 17.5 (beta) - FAIL, no Apple Pay banner displayed
  • iOS 17.4.1 - FAIL, no Apple Pay banner displayed
  • iOS 17.2.1 - FAIL, no Apple Pay banner displayed
  • iOS 16.6.1 - PASS, Apple Pay banner is displayed
  • iOS 15.8.1 - PASS, Apple Pay banner is displayed

Live Demo

https://modelviewer-extended-params.glitch.me/

Version

  • model-viewer: any

Browser Affected

  • Chrome, version: xx.x.xxxx.xx
  • Edge
  • Firefox
  • IE
  • Safari 17

OS

  • Android
  • iOS 17
  • Linux
  • MacOS
  • Windows

AR

  • WebXR
  • SceneViewer
  • QuickLook
@elalish elalish added the flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue label May 13, 2024
@milesgreen
Copy link
Contributor Author

Hi @AdaRoseCannon

This is still an issue on iOS 18.0 beta (22A5282m)

When using ARQuickLook to view a USDZ file URL, the Apple Pay banner is able to display.
When viewing a USDZ blob, the Apple Pay banner fails to display.
When viewing a USDZ blob, the custom banner is able to display.

So it does seem that the issue is only when viewing a USDZ blob and trying to display an Apple Pay Banner at the same time.

@AdaRoseCannon
Copy link

Thank you for following up, I am chasing it up.

@milesgreen
Copy link
Contributor Author

Retesting. Still an issue in iOS 18.0 Dev Beta 5 (22A5326f)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue
Projects
None yet
Development

No branches or pull requests

3 participants