Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When focused or clicked, the slider track and thumb are supposed to become darker as per the spec #842

Closed
kitgrose opened this issue Jul 7, 2015 · 3 comments

Comments

@kitgrose
Copy link

kitgrose commented Jul 7, 2015

In the spec, the slider's colour changes from rgb(176, 176, 176) to rgb(238, 238, 238) when it has focus or is being clicked:

The sliders image from the Material Design spec

In practice, this doesn't seem to be implemented in MDL (the track stays the same colour), in both Safari and Chrome on OS X Version 10.10.4.

@sgomes
Copy link
Contributor

sgomes commented Jul 8, 2015

Wow, good eyes, @kitgrose! Can't believe how many times I looked at that image and never noticed o_O

I'll see if I can cook up a fix soon.

@Garbee
Copy link
Collaborator

Garbee commented Jul 8, 2015

It's the subtle things in the spec that drive us mad.

@sgomes
Copy link
Contributor

sgomes commented Jul 1, 2016

Not feasible to fix in v1. For v2, the slider is being rewritten as part of #4494.

@sgomes sgomes closed this as completed Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants