Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Grid List v2 Component #4498

Closed
traviskaufman opened this issue Jun 29, 2016 · 5 comments
Closed

Implement Grid List v2 Component #4498

traviskaufman opened this issue Jun 29, 2016 · 5 comments

Comments

@traviskaufman
Copy link
Contributor

Spec reference: https://www.google.com/design/spec/components/grid-lists.html#grid-lists-specs

@jakub-swierk
Copy link

Do you have plan to support for the tiles of different sizes? If so, how?

  • Grid layout is not supported
  • Flexbox can't handle different tile sizes

I see there two ways:

  • Use flexbox layout and give free hand to host environment to do layout (example: grid layout polyfill)
  • Handle layout via javascript

@Garbee
Copy link
Collaborator

Garbee commented Sep 21, 2016

Flexbox can't handle different tile sizes

Yes it can. You just individually set the flex-basis.

Handling it via JS-only is a extreme measure and we are avoiding that unless absolutely necessary with components. This layout piece is fairly critical, so requiring JS for basic usage is not feasible. We need to make sure the JavaScript is an enhancement and not required for basic functionality.

@jakub-swierk
Copy link

jakub-swierk commented Sep 21, 2016

Garbee, i know about it.
But i was talking about layout where you have tile with spans for 2 rows.

Example

Tiles hold content and can span one or more cells vertically or horizontally.

@Garbee
Copy link
Collaborator

Garbee commented Sep 21, 2016

We can always do a grid base with flex fallback and enhance with JS for the columnar support. We need to remember that the css-only methods don't need to be perfect fidelity as that is only achievable with JS in some cases. So long as things render fine-enough without JS it is good to muster.

@sfdexter
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants