Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely rewrite the slider #1738

Open
sgomes opened this issue Oct 13, 2015 · 0 comments
Open

Completely rewrite the slider #1738

sgomes opened this issue Oct 13, 2015 · 0 comments
Assignees
Milestone

Comments

@sgomes
Copy link
Contributor

sgomes commented Oct 13, 2015

mdl-slider is implemented with native styling on the HTML range element. This is causing a number of problems:

  • Since these properties are all prefixed and behave slightly differently, we essentially have three different implementations.
  • There are differences even within the same browser family (see Slider Thumb not showing in Microsoft Edge on Windows 10 #1625).
  • There are hard to fix bugs due to the Material Design spec requiring things the native component doesn't expect (such as resizing the thumb, see Slider frustrating on mobile #1445).
  • There are certain parts of the spec we simply can't implement in certain browsers, particularly around animations.
  • The current implementation is incomplete, and only covers continuous sliders. Adding the rest would be very difficult, given the limitations above.

We should instead switch to a similar approach to the one we use in checkboxes and radio buttons, where we have a hidden native element for state and accessibility, and we render our own styling on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant