Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs are not accessible #187

Closed
davidchisnall opened this issue May 21, 2020 · 4 comments
Closed

Logs are not accessible #187

davidchisnall opened this issue May 21, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@davidchisnall
Copy link

I am reviewing a patch that failed to build on Windows:

https://reviews.llvm.org/D80218/new/

This is surprising, given that the submitter uses Windows but I wanted to check the logs before I merged it. The link to the build logs is:

https://storage.cloud.google.com/llvm-premerge-checks/results/amd64_windows_visualstudio-530/console-log.txt

This requires a Google Account login. I do not have a Google Account, I do not want to have a Google Account, and at no point has it ever been raised that agreeing to Google's privacy policy should be a prerequisite for contributing to LLVM, yet I cannot commit this patch without understanding why this test is failing.

There is no reason that build logs should be private (seeing Phabricator pages without commenting on them does not require logging in), so the simplest solution would be to store the build logs somewhere publicly accessible.

@davidchisnall davidchisnall added the bug Something isn't working label May 21, 2020
@joker-eph
Copy link
Contributor

@ChristianKuehnel
Copy link
Collaborator

@davidchisnall, I fully agree! Thank you for raising this issue!

These logs were configured to be public, as are those for Linux. I double checked the storage configuration and this looks like a bug somewhere in the Cloud Storage. I raised a bug there (ticket 157393846).

@ChristianKuehnel ChristianKuehnel self-assigned this May 25, 2020
@ChristianKuehnel
Copy link
Collaborator

@davidchisnall can you please try this URL:
https://storage.googleapis.com/llvm-premerge-checks/results/amd64_windows_visualstudio-530/console-log.txt

That seems to be a different API to the same file. If that works, we'll use that URL for all future builds...

@davidchisnall
Copy link
Author

Yup, that one works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants