Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KSP2] Annotations got use-site target when there are none specified #1882

Closed
kuanyingchou opened this issue May 10, 2024 · 2 comments · Fixed by #2058
Closed

[KSP2] Annotations got use-site target when there are none specified #1882

kuanyingchou opened this issue May 10, 2024 · 2 comments · Fixed by #2058
Assignees
@neetopia
Labels
bug Something isn't working
Milestone
2.1

Comments

@kuanyingchou
Copy link
Collaborator

KSP2 sees annotations applied on properties without use-site target having a non-null useSiteTarget when the origin is KOTLIN_LIB, but useSiteTarget is null when the origin is KOTLIN or in KSP1.

Repro: kuanyingchou@e707930
@neetopia neetopia self-assigned this May 16, 2024
@neetopia neetopia added the bug Something isn't working label May 16, 2024
@neetopia neetopia added this to the 2.1 milestone May 16, 2024
@neetopia
Copy link
Contributor

This does seems to be more correct, is this behavior change a blocking issue for you?

@kuanyingchou
Copy link
Collaborator Author

Yes, we do additional filtering in XProcessing and this leads to missing annotations. Also the behavior is different between when the origin is KOTLIN_LIB and other origins.

@ting-yuan ting-yuan mentioned this issue Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neetopia neetopia

Labels
bug Something isn't working
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

Do not use compiler hard-coded use-site target ting-yuan/ksp
2 participants
@kuanyingchou @neetopia