Set build config via BuildOptions #421
Conversation
halvards
force-pushed
the
programmatic-build-config
branch
from
9bae8e0
to
31f812c
Compare
Enables programmatically overriding build configs when ko is embedded in another tool. Related: ko-build#340, ko-build#419
halvards
force-pushed
the
programmatic-build-config
branch
from
31f812c
to
bfd6cee
Compare
pkg/commands/resolver_test.go
Outdated
| res, err := builder.Build(ctx, "ko://github.com/google/ko/test") | ||
| if err != nil { | ||
| t.Fatalf("builder.Build(): %v", err) | ||
| // TODO This test accesses the network and is slow. Implement a dry-run mode? |
There was a problem hiding this comment.
Could revive this issue: #295
I think it's slow from hitting base image stuff?
There was a problem hiding this comment.
Yes, it's slow because of the default base image on gcr.io.
#295 looks interesting. For now, I've pushed another commit that uses a local in-memory registry for these unit tests.
There was a problem hiding this comment.
For now, I've pushed another commit that uses a local in-memory registry for these unit tests.
Brilliant.
Tests create a local registry (using ggcr) with a dummy base image. This speeds up tests, since they don't need to hit gcr.io to fetch the default distroless base image.
Codecov Report
@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 53.39% 53.50% +0.10%
==========================================
Files 36 36
Lines 1826 1828 +2
==========================================
+ Hits 975 978 +3
+ Misses 700 699 -1
Partials 151 151
Continue to review full report at Codecov.
|
Enables programmatically overriding build configs when ko is embedded in another tool.
Also minor cleanup of the unit test for
NewPublisher().Related: #340, #419