Add flag and PublishOption for destination repo #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables programmatically setting the destination image repository when embedding ko's `publish` functionality in other tools. See ko-build#348
halvards
added a commit
to halvards/ko
that referenced
this pull request
Apr 29, 2021
This commit removes the `DockerRepo` config option and `--docker-repo` flag from the PR. New PR with the extracted config option: ko-build#351
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 38.24% 38.27% +0.03%
==========================================
Files 33 33
Lines 1527 1523 -4
==========================================
- Hits 584 583 -1
+ Misses 849 846 -3
Partials 94 94
Continue to review full report at Codecov.
|
|
Thanks for making this change. I think I'm convinced that grabbing the env var doesn't belong in I'm still a bit less convinced that it therefore needs to be a separate flag. Can we compromise and make Then, to embed this in skaffold (or elsewhere) we can make wdyt? |
|
Thanks for the quick reply! Yes, that SGTM, I'll go ahead and make the change. The flag isn't required for embedding, I just added it for consistency, since all the other fields in |
This enables programmatically setting the destination image repository and avoids exposing a flag.
imjasonh
reviewed
Apr 29, 2021
README.md
Outdated
| @@ -68,6 +68,9 @@ e.g.: | |||
| - `KO_DOCKER_REPO=gcr.io/my-project`, or | |||
| - `KO_DOCKER_REPO=my-dockerhub-user` | |||
|
|
|||
| If both the flag and the environment variable are set, the flag value takes | |||
There was a problem hiding this comment.
This change can be removed now.
imjasonh
approved these changes
Apr 30, 2021
jonjohnsonjr
approved these changes
Apr 30, 2021
halvards
added a commit
to halvards/ko
that referenced
this pull request
May 24, 2021
- Export functions and a variable to enable embedding of ko's `publish` functionality to be embedded in other tools. See GoogleContainerTools/skaffold#5611 - Remove DockerRepo PublishOption and flag. This removes the `DockerRepo` config option and `--docker-repo` flag from the PR. New PR with the extracted config option: ko-build#351 - Fix copyright headers for boilerplate check. - Use DockerRepo PublishOption instead of env var. - Override defaultBaseImage using BuildOptions. Remove exported package global SetDefaultBaseImage and instead allow programmatic override of the default base image using the field `BaseImage` in `options.BuildOptions`. Also fix copyright header years. - Add BuildOptions parameter to getBaseImage This enables access to BaseImage for programmatically overriding the default base image from `.ko.yaml`. - Add UserAgent to BuildOptions and PublishOptions This enables programmatically overriding the `User-Agent` HTTP request header for both pulling the base image and pushing the built image. - Rename MakeBuilder to NewBuilder and MakePublisher to NewPublisher. For more idiomatic constructor function names.
halvards
added a commit
to halvards/ko
that referenced
this pull request
May 24, 2021
- Export functions and a variable to enable embedding of ko's `publish` functionality to be embedded in other tools. See GoogleContainerTools/skaffold#5611 - Remove DockerRepo PublishOption and flag. This removes the `DockerRepo` config option and `--docker-repo` flag from the PR. New PR with the extracted config option: ko-build#351 - Fix copyright headers for boilerplate check. - Use DockerRepo PublishOption instead of env var. - Override defaultBaseImage using BuildOptions. Remove exported package global SetDefaultBaseImage and instead allow programmatic override of the default base image using the field `BaseImage` in `options.BuildOptions`. Also fix copyright header years. - Add BuildOptions parameter to getBaseImage This enables access to BaseImage for programmatically overriding the default base image from `.ko.yaml`. - Add UserAgent to BuildOptions and PublishOptions This enables programmatically overriding the `User-Agent` HTTP request header for both pulling the base image and pushing the built image. - Rename MakeBuilder to NewBuilder and MakePublisher to NewPublisher. For more idiomatic constructor function names.
jonjohnsonjr
pushed a commit
that referenced
this pull request
May 25, 2021
- Export functions and a variable to enable embedding of ko's `publish` functionality to be embedded in other tools. See GoogleContainerTools/skaffold#5611 - Remove DockerRepo PublishOption and flag. This removes the `DockerRepo` config option and `--docker-repo` flag from the PR. New PR with the extracted config option: #351 - Fix copyright headers for boilerplate check. - Use DockerRepo PublishOption instead of env var. - Override defaultBaseImage using BuildOptions. Remove exported package global SetDefaultBaseImage and instead allow programmatic override of the default base image using the field `BaseImage` in `options.BuildOptions`. Also fix copyright header years. - Add BuildOptions parameter to getBaseImage This enables access to BaseImage for programmatically overriding the default base image from `.ko.yaml`. - Add UserAgent to BuildOptions and PublishOptions This enables programmatically overriding the `User-Agent` HTTP request header for both pulling the base image and pushing the built image. - Rename MakeBuilder to NewBuilder and MakePublisher to NewPublisher. For more idiomatic constructor function names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables programmatically setting the destination image repository
when embedding ko's
publishfunctionality in other tools.See discussion in #348 for additional context.