Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Add KEDA-scaling for Sources #423

Closed
nachocano opened this issue Nov 26, 2019 · 5 comments · Fixed by #551
Closed

Add KEDA-scaling for Sources #423

nachocano opened this issue Nov 26, 2019 · 5 comments · Fixed by #551
Assignees
Labels
priority/2 Nice to have feature but doesn't block current release defined by release/*
Milestone

Comments

@nachocano
Copy link
Member

nachocano commented Nov 26, 2019

Problem
Our PubSub-based Sources are Pull-based. Given that our receive adapter polls for new messages, it’s hard to decide when to scale it out. In other words, the draining of the PubSub subscriptions will eventually become a throughput bottleneck.

There are some initial talks in the Sources WG regarding Pull-based sources and how to scale them. @aslom suggested KEDA. Either with KEDA or something else, we will need to read metrics from Stackdriver to see how “congested” the subscription is and inform the scaling mechanism. See details on metrics here.

Exit Criteria
Being able to scale out our receive adapters.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
2-3 weeks

@nachocano nachocano added the priority/2 Nice to have feature but doesn't block current release defined by release/* label Nov 27, 2019
@nachocano
Copy link
Member Author

As pointed out by @yolocs , KEDA seems to already be using SD metrics to scale PubSub... https://github.com/kedacore/keda/blob/master/pkg/scalers/gcp_pub_sub_scaler.go#L139
Thanks @yolocs for the pointer.

@nachocano
Copy link
Member Author

/assign @ian-mi
in case you are interested, this can have a high impact... and I'd be interested in helping out...

@nachocano nachocano added this to the v0.13.0-M2 milestone Feb 5, 2020
@nachocano nachocano changed the title Data plane Scalability Sources data plane scalability Feb 5, 2020
@nachocano
Copy link
Member Author

WIP on the kafka source knative/eventing-contrib#886

@nachocano nachocano assigned nachocano and unassigned ian-mi Feb 6, 2020
@nachocano
Copy link
Member Author

Starting working on some of this to see if it would work... This will require quite some work to have something generic enough for other sources to benefit...
fyi @nlopezgi, we can talk more offline

@nachocano nachocano changed the title Sources data plane scalability Add KEDA-scaling for Sources Feb 18, 2020
@nachocano
Copy link
Member Author

Integration done, seems to be working for the different sources.
Still needed to add UTs and documentation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/2 Nice to have feature but doesn't block current release defined by release/*
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants