feat: implement std.remove and std.removeAt #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparkprime
reviewed
May 3, 2023
| availableSince: 'upcoming', | ||
| description: html.paragraphs([ | ||
| ||| | ||
| Remove given <code>elem</code> from <code>arr</code>. |
There was a problem hiding this comment.
Specifically the first one found
There was a problem hiding this comment.
Oh it actually removes all of them! Say that then :)
There was a problem hiding this comment.
Actually it seems the go version only removes the 1st one and that's the semantics i'd expect from the name of the function so I guess that's what you wanted.
There was a problem hiding this comment.
Yes, it is for first occurrence. Made appropriate changes.
sparkprime
reviewed
May 3, 2023
|
|
||
| removeAt(arr, at):: [ | ||
| arr[i], | ||
| for i in std.range(0, std.length(arr) - 1) |
There was a problem hiding this comment.
Edit: Never mind, this is fine
sparkprime
reviewed
May 3, 2023
stdlib/std.jsonnet
Outdated
| @@ -1710,4 +1710,16 @@ limitations under the License. | |||
| round(x):: std.floor(x + 0.5), | |||
|
|
|||
| isEmpty(str):: std.length(str) == 0, | |||
|
|
|||
| remove(arr, elem):: [ | |||
There was a problem hiding this comment.
I think you can express this as something like:
local indexes = std.find(arr, at);
if std.length(indexes) == 0 then
return arr
else
return std.removeAt(arr,indexes[0])So it does not remove all of them
rohitjangid
force-pushed
the
feat/array-remove
branch
from
15a935f
to
74ec9b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
std.removeandstd.removeAtgo-jsonnet PR: google/go-jsonnet#689