Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit command with a non-zero exit code if the externs contain an error #31

Conversation

realityforge
Copy link
Contributor

No description provided.

@realityforge realityforge force-pushed the FailCommandIfExternsContainErrors branch from 413f05e to bb6d23a Compare April 1, 2019 04:38
@realityforge
Copy link
Contributor Author

It should be noted that this is step 1 for achieving #28

@jDramaix
Copy link
Member

jDramaix commented Jun 7, 2019

In the last commits, I've introduced a Problems class
I would prefer to add a reportError() to this class and change the implementation of hasErrors to return true if an error has been reported.
When reportError returns true, the generator exits with a non-zero exit code

@realityforge
Copy link
Contributor Author

Seems reasonable. I will reimplement it that way the next time I get back to this

@realityforge realityforge deleted the FailCommandIfExternsContainErrors branch June 9, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants