Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providers don't do circular dependency detection #626

Closed
gissuebot opened this issue Jul 7, 2014 · 3 comments
Closed

Providers don't do circular dependency detection #626

gissuebot opened this issue Jul 7, 2014 · 3 comments
Labels

Comments

@gissuebot
Copy link

From sberlin on April 30, 2011 11:33:34

Providers can fail with StackOverflowErrors if the circular dependencies are purely with providers.  The current "re-entrant provider" failure only works if one of the dependencies didn't come from a Provider.

Providers should have full circular dependency detection, similar to how constructor bindings do it.

Original issue: http://code.google.com/p/google-guice/issues/detail?id=626

@gissuebot
Copy link
Author

From sberlin on April 30, 2011 08:38:45

fixed in r=1543

Status: Fixed

@gissuebot
Copy link
Author

From sberlin on April 30, 2011 08:39:07

( r1543 , that is)

@gissuebot
Copy link
Author

From mcculls on May 04, 2011 11:03:02

Testcase patch that shows interesting conflict wrt. circular provider proxies and injection listeners

Attachment: gist
   CIRCULAR_DEPENDENCY_WITH_INJECTION_LISTENER_TEST.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant